fix: mark all routers DoNotWaitForSearchValue #10020
Merged
+39
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
changed the title
Jorropo
changed the title
Jorropo
force-pushed
the
fix/9927
branch
2 times, most recently
from
d3ffb8c
to
1c22096
Compare
aschmahmann
requested changes
Jul 21, 2023
That means if the DHT has finished searching and no one responded over pubsub *yet*, we will not spend 1 minute searching for no reason. This also include other error handling bug fixes inside `go-libp2p-routing-helpers`. Fixes: #9927
Stop making this configurable let everything race like it used to do.
Jorropo
changed the title
Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That means if the DHT has finished searching and no one responded over pubsub yet, we will not spend 1 minute searching for no reason.
This also include other error handling bug fixes inside
go-libp2p-routing-helpers.Fixes: #9927
Depends on libp2p/go-libp2p-routing-helpers#75